Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'nonnegative' to 'non-negative' for consistency #942

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #942 (6858cd2) into master (5471f12) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files          51       51           
  Lines        4162     4162           
=======================================
  Hits         3154     3154           
  Misses       1008     1008           
Files Changed Coverage
pkg/JuliaExperimental/gap/finvar.gi 0.00%
pkg/JuliaInterface/gap/adapter.gi 100.00%

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.k.
Concerning consistency, I think "nonnegative" occured more often in GAP.jl than "non-negative". Oscar.jl has a clear majority for "non-negative", and gap-system has a small majority for "non-negative". So let us switch to "non-negative".

@ThomasBreuer ThomasBreuer merged commit dfc41a3 into master Sep 19, 2023
14 checks passed
@ThomasBreuer ThomasBreuer deleted the mh/nonnegative branch September 19, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants