Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (::<AbstractString)(::GapObj) #941

Closed
wants to merge 1 commit into from
Closed

Remove (::<AbstractString)(::GapObj) #941

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Member

This is part of PR #936 by @lgoettgens and already mergable by itself.

It is also technically a breaking change, I guess, although I don't know of any code relying on this... but who knows....

@lgoettgens
Copy link
Member

lgoettgens commented Sep 18, 2023

I do not see any difference between this and #936 (except for toggling the Aqua test switch).
Or is this intended to have a separate release note item for the breaking change?

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #941 (81f63c6) into master (1ad0308) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   75.72%   75.71%   -0.02%     
==========================================
  Files          51       51              
  Lines        4161     4159       -2     
==========================================
- Hits         3151     3149       -2     
  Misses       1010     1010              
Files Changed Coverage
src/constructors.jl ø
src/gap_to_julia.jl 100.00%

@fingolfin
Copy link
Member Author

The other PR was marked as draft and I thought there is more work to be done there, so I thought we could merge this part of it already now -- but I now see you actually "completed" PR #936 now, in which case I am of course also happy to just merge that one directly :-)

@fingolfin fingolfin closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants