Bump Aqua compat #933
Merged
Bump Aqua compat #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Sep 3, 2023
|
complains about possible type piracy due to (I think) GapObj (again) |
|
I'll look into this next week. Could possibly be a bug in the new Aqua stuff as well, there are no tests with kwargs if I remember correctly. |
Indeed a bug in Aqua (see JuliaTesting/Aqua.jl#171). Your original fix for Unions like |
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 51 51
Lines 4170 4170
=======================================
Hits 3155 3155
Misses 1015 1015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.