Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JuliaFunction and a bunch of C code #1047

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (696615b) to head (b3c2d48).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/JuliaInterface/src/JuliaInterface.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   74.32%   75.52%   +1.20%     
==========================================
  Files          55       55              
  Lines        4514     4478      -36     
==========================================
+ Hits         3355     3382      +27     
+ Misses       1159     1096      -63     
Files with missing lines Coverage Δ
pkg/JuliaInterface/gap/JuliaInterface.gd 100.00% <ø> (ø)
pkg/JuliaInterface/gap/JuliaInterface.gi 93.25% <100.00%> (-0.50%) ⬇️
pkg/JuliaInterface/src/JuliaInterface.c 74.24% <75.00%> (+7.36%) ⬆️

... and 2 files with indirect coverage changes

@fingolfin fingolfin merged commit e60382d into master Sep 20, 2024
21 checks passed
@fingolfin fingolfin deleted the mh/remove-JuliaFunction branch September 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant