bib: run "dnf" inside the container again #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
bib-container-dnf-test3
branch
from
25e576e
to
ca0a1e9
Compare
achilleas-k
previously approved these changes
Oct 10, 2024
mvo5
force-pushed
the
bib-container-dnf-test3
branch
from
a058d4d
to
3318a42
Compare
In 17d3b56 osbuild-dnf-json was changed to run outside the container. This lead to a regression in accessing subscribed content. This commit partially reverts this commit to run dnf again inside the container so that we have access to the /run/secrets and RHEL repos.
This commit adds a test that ensures that InitDNF() results in triggering the dnf plugin that updates the subscriptions.
This commit adds a test for the DNF solver inside a subscribed RHEL container.
This commit moves the logic of dealing with `osbuild-json-dnf` for containers into a new container dnf `cntdnf` go module. Also move the integration test for dnfjson with subscribed/normal content there.
This commit wires up the needed credentials and scaffolding to
run the integration tests about subscribed content in containers
via tmt. For this it passes in the `RHSM_{ORG,ACTIVATION_KEY}`
secrets and runs the go tests as root.
This splits the go unit tests into a new github action to avoid
having to wait for both to finish.
For unknown and inexplicable reasons the progressbar does not generate output when run with testingfarm. This is not observed on a normal fedora40 or the GH runners, the reason is unknown and should be investigated but to unblock us the test is currently disabled in this specific environment.
mvo5
force-pushed
the
bib-container-dnf-test3
branch
from
3318a42
to
1362165
Compare
mvo5
commented
Oct 10, 2024
mvo5
commented
Oct 16, 2024
Ondrej suggested to remove the `cntdnf` package again and move the code back into container. My original thinking was to have a separate package because it a "container" should not need to have knowledge about dnf and we could have a `cnfapt` later but then YAGNI and we can always split it out later.
ondrejbudai
approved these changes
Oct 18, 2024
|
Should we merge this now to fix the immediate issue and then follow up with a switch back to using |
achilleas-k
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 17d3b56 osbuild-dnf-json was changed to run outside the
container. This lead to a regression in accessing subscribed
content. This commit partially reverts this commit to run
dnf again inside the container so that we have access to
the /run/secrets and RHEL repos.
This also adds a bunch of extra tests that needs to run
on a fedora/rhel/centos machine to test dnfjson and
subscriptions inside the container environment. Those
will only run in testingfarm (or locally) not in GH actions.
Closes: https://issues.redhat.com/browse/BIFROST-429
P.S. We should probably also look into how to inject osbuild-dnf-json into
the container, this way is not ideal, we maybe need to reconsider
putting it all into a single file again or think about other ways to make
this slightly easier. The tests/refactor hopefully makes this slightly easier
now.