From f1b126b2e49bd1c6e30aa970e3728cccfbee2093 Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Thu, 1 Aug 2024 22:09:49 +0200 Subject: [PATCH 1/3] Apply black suggestions as of 2024-08-01 --- openqa_review/browser.py | 1 - openqa_review/openqa_review.py | 22 +++++++++++----------- openqa_review/tumblesle_release.py | 2 -- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/openqa_review/browser.py b/openqa_review/browser.py index a0a965c..c245609 100644 --- a/openqa_review/browser.py +++ b/openqa_review/browser.py @@ -71,7 +71,6 @@ def filename_to_url(name): class Browser(object): - """download relative or absolute url and return soup.""" def __init__(self, args, root_url, auth=None, headers={}, api_key=None): diff --git a/openqa_review/openqa_review.py b/openqa_review/openqa_review.py index 7770cf4..93c7b2b 100755 --- a/openqa_review/openqa_review.py +++ b/openqa_review/openqa_review.py @@ -688,7 +688,6 @@ def _parse_issue_timestamp(timestamp): class Issue(object): - """Issue with extra status info from issue tracker.""" def __init__(self, bugref, bugref_href, query_issue_status=False, progress_browser=None, bugzilla_browser=None): @@ -886,7 +885,6 @@ def _format_all_urls_using_markdown(string): class IssueEntry(object): - """List of failed test scenarios with corresponding bug.""" def __init__(self, args, root_url, failures, test_browser=None, bug=None): @@ -1162,13 +1160,17 @@ def __str__(self): "status_badge": status_badge_str[self.status_badge], # everything that is 'NEW_ISSUE' should be product issue but if tests have changed content, then # probably openqa issues For now we can just not easily decide unless we use the 'bugrefs' mode - "new_openqa_issues": "" - if abbrev - else issue_listing("**New openQA-issues:**", self.issues["new"]["openqa"], self.args.show_empty), - "existing_openqa_issues": "" - if abbrev - else issue_listing( - "**Existing openQA-issues:**", self.issues["existing"]["openqa"], self.args.show_empty + "new_openqa_issues": ( + "" + if abbrev + else issue_listing("**New openQA-issues:**", self.issues["new"]["openqa"], self.args.show_empty) + ), + "existing_openqa_issues": ( + "" + if abbrev + else issue_listing( + "**Existing openQA-issues:**", self.issues["existing"]["openqa"], self.args.show_empty + ) ), "new_product_issues": issue_listing( "**New Product bugs:**", self.issues["new"]["product"], self.args.show_empty @@ -1183,7 +1185,6 @@ def __str__(self): class ProductReport(object): - """Read overview page of one job group and generate a report for the product.""" def __init__(self, browser, job_group_url, root_url, args): @@ -1527,7 +1528,6 @@ def _pgroup_prefix(group): class Report(object): - """openQA review report.""" def __init__(self, browser, args, root_url, job_groups): diff --git a/openqa_review/tumblesle_release.py b/openqa_review/tumblesle_release.py index 1468bc6..4f5297a 100755 --- a/openqa_review/tumblesle_release.py +++ b/openqa_review/tumblesle_release.py @@ -68,14 +68,12 @@ def scenario(job): class UnsupportedRsyncArgsError(Exception): - """Unsupported rsync arguments where used.""" pass class TumblesleRelease(object): - """Check for releasable builds and release them as TumbleSLE if they are at least as good as the current one.""" def __init__(self, args): From 1dda360d25414e9cfb7675cafcaff07af5d9e87c Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Fri, 2 Aug 2024 09:28:24 +0200 Subject: [PATCH 2/3] tox: Add python3.13 which is already in Tumbleweed --- tox.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/tox.ini b/tox.ini index 7f7bd26..7610ca7 100644 --- a/tox.ini +++ b/tox.ini @@ -18,6 +18,7 @@ python = 3.10: py310 3.11: py311 3.12: py312 + 3.13: py313 [testenv:black] deps = From f499e4350c98a16ba64ddbb4bf898794aaa67992 Mon Sep 17 00:00:00 2001 From: Oliver Kurz Date: Fri, 2 Aug 2024 09:33:44 +0200 Subject: [PATCH 3/3] tox: Update tested python versions Keep 3.6 for openSUSE Leap/SLE. Use more recent versions available in openSUSE Tumbleweed as well as ubuntu-latest. --- .github/workflows/python-package.yaml | 8 ++------ tox.ini | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/python-package.yaml b/.github/workflows/python-package.yaml index 50c1091..9239ac5 100644 --- a/.github/workflows/python-package.yaml +++ b/.github/workflows/python-package.yaml @@ -10,12 +10,8 @@ jobs: matrix: python-version: - '3.6' - - '3.7' - - '3.8' - - '3.9' - - '3.10' - '3.11' - - '3.12.0-alpha - 3.12.0' + - '3.12' include: - os: "ubuntu-latest" - os: "ubuntu-20.04" @@ -60,7 +56,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v3 with: - python-version: '3.10' + python-version: '3.12' - name: Install dependencies run: python -m pip install tox - run: python -m tox -e ${{ matrix.test-type }} diff --git a/tox.ini b/tox.ini index 7610ca7..f72a947 100644 --- a/tox.ini +++ b/tox.ini @@ -4,7 +4,7 @@ # and then run "tox" from this directory. [tox] -envlist = flake8,black,doctests,py{36,37,38,39,310},cov +envlist = flake8,black,doctests,py{36,311,312,313},cov deps = -rrequirements.txt skip_missing_interpreters = true