Dart build 0.7.1-alpha.1 does not compile

[yholkamp]

Describe the bug

The 0.7.1-alpha.1 build of the Dart Kratos client library does not compile as it calls an invalid method.

To Reproduce

Steps to reproduce the behavior:

1. Include the library in a Flutter project

2. Run flutter build appbundle

3. Observe the following errors:

    ../../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/ory_kratos_client-0.7.1-alpha.1/lib/model/generic_error.dart:101:20: Error: Method not found: 'Object.mapFromJson'.
              : Object.mapFromJson(json[r'details']),                       
                       ^^^^^^^^^^^                                          
    ../../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/ory_kratos_client-0.7.1-alpha.1/lib/model/volume.dart:117:20: Error: Method not found: 'Object.mapFromJson'.
              : Object.mapFromJson(json[r'Status']),                        
                       ^^^^^^^^^^^                                          
   

Expected behavior

These lines attempt to deserialize a map of string to object properties from JSON, in the case of Dart the goal should be a Map here and not an Object as the spec dictates. One way to adjust that may be to change such lines in to a json[r'details'] as Map cast rather, as the input is already deserialized and maybe in the right format.

Environment

• Version: Flutter 2.0.2
• Dart v2.12.1

Additional context

The root cause seems to be with the code generator:

• [dart] "type: object" with no properties generates invalid code swagger-api/swagger-codegen#9182 describes the same issue, as does
• [BUG] [Dart] Object.mapFromJson method not found error in Map<String, Object> attribute deserialization OpenAPITools/openapi-generator#9272

[aeneasr]

Could you try alpha.3?

[yholkamp]

@aeneasr I'm happy to but I'm not seeing that version released yet at https://pub.dev/packages/ory_kratos_client/versions, is that underway?

[aeneasr]

Whoops, my bad, looks like I was in the future already. We only released 0.7.1 :D

[provokateurin]

I just tried the fix @yholkamp suggested and it works: https://github.com/stack11/sdk

[aeneasr]

Probably caused by: swagger-api/swagger-codegen#7418 (comment)

[aeneasr]

I just saw that the dart generator is probably outdated and also does not support OAS3 which we are now using. It looks like we have some alternatives:

• https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/dart.md
• https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/dart-dio.md
• https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/dart-dio-next.md
• https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/dart-jaguar.md

I don't know any Dart so I don't know the differences between dio / dio-next and jaguar. From what I see on the forums, dart-dio looks like it's better supported?

[provokateurin]

Those are frameworks. I only know dio, but it's pretty good as far as I remember.

[provokateurin]

I tried dio and it also seems horribly outdated. Stuff like null-safety is also not there.

[yholkamp]

@aeneasr since adding this ticket I've had success with the dart2 generator. One limitation was the lack of DELETE call support (for logout) but that's resolved in master via OpenAPITools/openapi-generator#10100 , it will be in the 5.2.1 release but is not out yet. Once it's released I'd propose moving the dart client over to that, alternatively the generator works right now in 5.2.0 with the note that the logout endpoint fails.

[aeneasr]

Ah nice! What's the difference between dart and dart2? Is it just the generator or more?

[provokateurin]

Dart 1 is deprecated as a whole. Nobody should use it anymore. Maybe that also fixes other issues I/we have been facing?

[aeneasr]

Ahhh, ok, that makes sense! Then yeah, all for going with dart2 generator!

[provokateurin]

But the generated code is dart 2 compliant (see the @dart=2.0) comments in the files.

[aeneasr]

So should we change to the dart2 generator? It isn't documented yet :/

[aeneasr]

Ok, so I have merged the changes and triggered a release. Let's see if it works now. A few questions from my side:

1. How would testing the SDK look like for Dart? Can we ensure that it compiles before we push it to remote?
2. Should we switch to dart2 and if so, are there some resources on its maturity? And how would we switch (couldn't find an officially supported page)
3. Can you check if the newest release compiles now?

[aeneasr]

https://pub.dev/packages/ory_kratos_client/versions/0.7.1-alpha.2

[aeneasr]

Superseded #109