Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less flaky rule tests #973

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jun 10, 2022

Instead of (flaky) fixed sleeps, we now use assert.Eventually
to wait until the rule changes were propagated.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security.
    vulnerability, I confirm that I got green light (please contact [email protected]) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

Instead of (flaky) fixed sleeps, we now use assert.Eventually
to wait until the rule changes were propagated.
@hperl hperl requested a review from aeneasr as a code owner June 10, 2022 08:39
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #973 (d576202) into master (c4836f5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files         106      106           
  Lines        4723     4723           
=======================================
  Hits         3118     3118           
  Misses       1324     1324           
  Partials      281      281           
Impacted Files Coverage Δ
internal/httpclient/models/health_status.go 0.00% <ø> (ø)
internal/httpclient/models/json_web_key.go 0.00% <ø> (ø)
internal/httpclient/models/json_web_key_set.go 0.00% <ø> (ø)
internal/httpclient/models/rule.go 0.00% <ø> (ø)
internal/httpclient/models/rule_handler.go 0.00% <ø> (ø)
internal/httpclient/models/rule_match.go 0.00% <ø> (ø)
internal/httpclient/models/upstream.go 0.00% <ø> (ø)
internal/httpclient/models/version.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f714cd3...d576202. Read the comment docs.

@aeneasr aeneasr merged commit 6ee6a73 into ory:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants