-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow both string and []string in aud field #822
Conversation
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 62.42% 62.47% +0.05%
==========================================
Files 102 102
Lines 4793 4813 +20
==========================================
+ Hits 2992 3007 +15
- Misses 1528 1531 +3
- Partials 273 275 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the code itself looks good to me 👍
27b603b
to
038ff2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great :) As @zepatrik pointed out please add a test :)
According to the specification, the
aud
field can either be an array of strings or a single string. Oathkeeper only supports arrays, which breaks the integration with IAM tools like Keycloak and forces users to use ugly hacks like setting an additional fake audience. This change adds support for strings to Oathkeeper.Related issue(s)
@aeneasr
#491
#601
#792
#810
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.