Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow both string and []string in aud field #822

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

m1pl
Copy link
Contributor

@m1pl m1pl commented Sep 16, 2021

According to the specification, the aud field can either be an array of strings or a single string. Oathkeeper only supports arrays, which breaks the integration with IAM tools like Keycloak and forces users to use ugly hacks like setting an additional fake audience. This change adds support for strings to Oathkeeper.

Related issue(s)

@aeneasr
#491
#601
#792
#810

Checklist

@m1pl m1pl requested a review from aeneasr as a code owner September 16, 2021 13:40
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #822 (d50c7a2) into master (1f1f03a) will increase coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
+ Coverage   62.42%   62.47%   +0.05%     
==========================================
  Files         102      102              
  Lines        4793     4813      +20     
==========================================
+ Hits         2992     3007      +15     
- Misses       1528     1531       +3     
- Partials      273      275       +2     
Impacted Files Coverage Δ
...peline/authn/authenticator_oauth2_introspection.go 81.38% <75.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1f03a...d50c7a2. Read the comment docs.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the code itself looks good to me 👍

@m1pl m1pl force-pushed the fix-aud branch 2 times, most recently from 27b603b to 038ff2b Compare September 17, 2021 09:04
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great :) As @zepatrik pointed out please add a test :)

@m1pl
Copy link
Contributor Author

m1pl commented Sep 20, 2021

@zepatrik @aeneasr I added tests.

@aeneasr aeneasr merged commit 1897f31 into ory:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants