-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introspection response #792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 62.21% 62.34% +0.13%
==========================================
Files 102 102
Lines 4782 4799 +17
==========================================
+ Hits 2975 2992 +17
Misses 1532 1532
Partials 275 275
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! However, unfortunately, I do not believe that it will resolve what you are trying to do, because the type assertion will always be false. It might make sense to use something like gjson.Get
to see if you have a string or an array in the audience. It would also make sense to add an e2e test to ensure that the feature works as expected :)
I try to fixing the issue related oauth2_introspection not parsing single string aud value
Based on this protocol https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation the audience field need to changed, to receive []string or string.
There are some solutions we can implement :
oathkeeper/pipeline/authn/authenticator_oauth2_introspection.go
Line 90 in e4e2263
Effort :
Effort :
So, because of that, I decide to create new struct named Fork and add the function modify struct in this PR.
With this Fork struct and this function the unit testing also work fine after I execute in my local.
Hopefully with this PR can help everyone that face same issue.
Thank you
Related issue(s)
#491
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.