Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intro preauth client once #723

Merged
merged 8 commits into from
May 21, 2021

Conversation

pike1212
Copy link
Contributor

@pike1212 pike1212 commented May 10, 2021

Related issue

#712

Proposed changes

Only initializes oauth client once during config stage per config and doesn't initialize when creating new introspector.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks much better :) These a few more things left to do but it's now something we can release :))

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think we can use require/assert for the equals comparison but otherwise this is exactly what I imagined! thank you :)

pipeline/authn/authenticator_oauth2_introspection_test.go Outdated Show resolved Hide resolved
pipeline/authn/authenticator_oauth2_introspection_test.go Outdated Show resolved Hide resolved
@pike1212
Copy link
Contributor Author

@aeneasr can this be merged?

@aeneasr
Copy link
Member

aeneasr commented May 21, 2021

Yes! :)

@aeneasr aeneasr merged commit 3a9ae1a into ory:master May 21, 2021
@aeneasr
Copy link
Member

aeneasr commented May 21, 2021

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants