fix: update shebangs to use bash from /usr/bin/env instead of /bin/ for better portability #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693
Proposed changes
As said in the issue, on some systems, bash doesn't lie in /bin/, but in other places, like /usr/local/bin/bash (FreeBSD) or even in unpredictable paths like /nix/store/y0vp7qcjz02rsgawlgmx8ilbh2wimcg5-system-path/bin/bash (NixOS).
It makes the installation impossible without modifying the Makefile.
This PR replaces all
/bin/bash
shebangs with/usr/bin/env bash
, improving portability.Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
I consider
/usr/bin env
to be more portable, because env is more likely to be in/usr/bin
than bash is to be in/bin
.