Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass context through to external requests #627

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

ptescher
Copy link
Contributor

@ptescher ptescher commented Jan 5, 2021

Proposed changes

Pass the request context through so that authenticator etc requests have a proper parent context.

This makes sure that the tracing frameworks like Jaeger get the whole picture.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Enables proper tracing through Jaeger etc
@ptescher ptescher force-pushed the feature/pass-context branch from a010880 to b7fa48f Compare January 5, 2021 22:15
@ptescher ptescher changed the title Pass context through to external requests chore: pass context through to external requests Jan 6, 2021
@aeneasr aeneasr merged commit ee25197 into ory:master Jan 28, 2021
@ptescher ptescher deleted the feature/pass-context branch March 18, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants