feat: Log invalid credentials on info level instead of error/warning #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catper
changed the title
aeneasr
requested changes
Sep 16, 2020
proxy/request_handler.go
Outdated
| Warn("No authentication handler was responsible for handling the authentication request") | ||
| // found will only be true if an authenticator was found AND authorisation was granted so check | ||
| // that this wasn't just a problem with the request | ||
| if err.Error() != helper.ErrUnauthorized.ErrorField { |
There was a problem hiding this comment.
This is always false because we set the error to err := errors.WithStack(helper.ErrUnauthorized) right before - so this can be removed :)
There was a problem hiding this comment.
i see your point :), guess i need to think about this a bit more.
the problem is, if this if statement is removed, then invalid credentials or an expired token will result in level=warning msg=No authentication handler was responsible for handling the authentication request getting logged, which is inaccurate and misleading.
catper
force-pushed
the
mac-se-catper
branch
from
3e51774 to
ae9cdfc
Compare
…uld not be granted
catper
force-pushed
the
mac-se-catper
branch
from
ae9cdfc to
30450ae
Compare
aeneasr
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#505
Proposed changes
Invalid credentials or a malformed request is really the client's responsibility and should therefore not be considered an error.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
In the best of worlds I would also like to not have an error logged in the scenario where e.g. the token was expired:
but that seems to be rather a large change. Is there any easy way to accomplish this?