-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working with NGINX auth_request #461
Comments
I think responding with a 403 when no rule matches is probably generally more in line with what would be expected? For me this is a go. Since the next version will include several breaking changes, I think we can add this as well. |
Hi @ecktom ,
Would you please help me to take a look and give me some advice? |
Hi @lanphan,
which should let any request through. I think your issues are at the misconfigured |
Hello contributors! I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue
Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic. Unfortunately, burnout has become a topic of concern amongst open-source projects. It can lead to severe personal and health issues as well as opening catastrophic attack vectors. The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone. If this issue was marked as stale erroneous you can exempt it by adding the Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you! Thank you 🙏✌️ |
NGINX is able to do authentication based on subrequest results using the auth_request directive. We're using this heavily with Oathkeeper as backing service.
NGINX however expects the subrequest to return either 200, 401 oder 403 as response code. If we're forwarding a request to Oathkeeper for which no rules are defined 404 is returned. For the NGINX this looks like the auth backend is not available. Thus the incoming request get's responded with 500.
Easiest fix for this might be making the response status code for the no rules available case configurable. Would you be up for a PR to implement this behavior?
The text was updated successfully, but these errors were encountered: