feat: Enable configuration of timeout settings for oauth2_client_credentials authoriser #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
catper
changed the title
|
Not sure what the failing test is about, I didn't change any dependencies. If anyone can help me sort this it out would be much appreciated! |
in the project root should resolve this! |
catper
force-pushed
the
client-credentials-timeout-config
branch
from
2cb4004 to
f592caa
Compare
catper
force-pushed
the
client-credentials-timeout-config
branch
from
f592caa to
ad3ecfe
Compare
that did indeed sort this out, thanks! |
|
Nicely done, I was about to work on this :) |
|
Awesome 🎉 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#442
This was also briefly discussed with @aeneasr on Slack
Proposed changes
Enable users to specify timeout for the oauth2_client_credentials authoriser, much in the same fashion as is possible for the oauth2_introspection authoriser.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
A lot of changes were generated when running
npm gen docs, which creates rather a lot of noise. Sorry about that.