fix: Move Prometheus validation stanza to local schema #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Prometheus endpoint cannot be validated by local json schema
Gist of the issue
The current v0.38.0-beta.2 release has introduced prometheus metrics and the following configuration stanza:
however the local config.schema.json does not contain it.
This is also the schema that is loaded on startup root.go which causes the command to fail with a validation error:
Proposed changes
The proposed change is to add the prometheus validation to the local schema
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further comments
I tested the compiled binary against an example configuration containing the prometheus stanza and everything works correctly