feat(prometheus): add docs #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
May 6, 2020
There was a problem hiding this comment.
Awesome, thank you! Just a bit of restructuring:
- Move .github/grafana/Oathkeeper-Dashboard.json to
contrib/grafana/Oathkeeper-Dashboard.json - Move .github/grafana/grafana.png to
https://github.com/ory/oathkeeper/tree/master/docs/static/img/docs/grafana.png
:)
docs/docs/configure-deploy.md
Outdated
| Now where you have a basic monitoring setup running you can extend it by building up nice visualizations eg. using Grafana. More information are available on [https://prometheus.io/docs/visualization/grafana/](https://prometheus.io/docs/visualization/grafana/). | ||
|
|
||
| We have a pre built Dashboard which you can use to get started quickly: | ||
| [Oathkeeper-Dashboard.json](../../.github/grafana/Oathkeeper-Dashboard.json). |
There was a problem hiding this comment.
Suggested change
| [Oathkeeper-Dashboard.json](../../.github/grafana/Oathkeeper-Dashboard.json). | |
| [Oathkeeper-Dashboard.json](https://github.com/ory/oathkeeper/tree/master/contrib/grafana/Oathkeeper-Dashboard.json). |
docs/docs/configure-deploy.md
Outdated
| We have a pre built Dashboard which you can use to get started quickly: | ||
| [Oathkeeper-Dashboard.json](../../.github/grafana/Oathkeeper-Dashboard.json). | ||
|
|
||
| <img src="../../.github/grafana/grafana.png" alt="ORY Oathkeeper - Cloud Native Identity & Access Proxy"> |
There was a problem hiding this comment.
<img
alt="ORY Oathkeeper with Prometheus and Grafana"
src={useBaseUrl('img/docs/grafana.png')}
/>
ecktom
force-pushed
the
feat/prom_docs
branch
3 times, most recently
from
a469ffe to
04fe0e4
Compare
|
You're awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Followup docs for #404
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.