allow specifying additional headers for the oauth introspection request #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Nov 18, 2019
This was referenced Nov 18, 2019
aeneasr
reviewed
Nov 19, 2019
| @@ -96,7 +106,7 @@ func (a *AuthenticatorOAuth2Introspection) Authenticate(r *http.Request, config | |||
| } | |||
|
|
|||
| if !i.Active { | |||
| return nil, errors.WithStack(helper.ErrForbidden.WithReason("Access token i says token is not active")) | |||
| return nil, errors.WithStack(helper.ErrUnauthorized.WithReason("Access token i says token is not active")) | |||
There was a problem hiding this comment.
Suggested change
| return nil, errors.WithStack(helper.ErrUnauthorized.WithReason("Access token i says token is not active")) | |
| return nil, errors.WithStack(helper.ErrUnauthorized.WithReason("The provided Access Token is invalid, expired, or malformed.")) |
| "introspection_request_headers": { | ||
| "title": "Introspection Request Headers", | ||
| "description": "Additional headers to be added to the introspection request.", | ||
| "type": "object" |
There was a problem hiding this comment.
Could you add an example please?
"examples": [{ "X-Whatever": "foo" }]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the option to specify additional headers to the oauth introspection request. The main use case is for adding an
X-Forwarded-Protoheader for communicating with an internal hydra instance.Checklist
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
developer guide (if appropriate)
Further comments
Assuming this is accepted in general, I'll also add this feature to the oauth client credentials athenticator