support multiple mutators #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkab
force-pushed
the
feature/support-multiple-mutators
branch
from
a1acca6 to
e458275
Compare
jakkab
force-pushed
the
feature/support-multiple-mutators
branch
from
e458275 to
a624aa0
Compare
|
😎 |
|
LMK when good for 👀 |
piotrmsc
reviewed
Aug 9, 2019
|
@aeneasr ready for review! |
jakkab
force-pushed
the
feature/support-multiple-mutators
branch
from
fe2d281 to
a624aa0
Compare
aeneasr
reviewed
Aug 12, 2019
There was a problem hiding this comment.
This looks super solid! Please:
- Add a section under "master" highlighting the change: https://github.com/ory/oathkeeper/blob/master/UPGRADE.md#master
- Update the docs ( https://github.com/ory/docs/tree/master/docs/oathkeeper ) from singular to plural!
Regarding the upgrade document, I think adding a pseudo-patch code section helps people the most. So something like this:
|
@aeneasr see ory/docs#193 |
|
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
implements #233
Proposed changes
Support multiple mutators
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.