Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json encode of config for "credentials_issuer" and "authorizer" during import #184

Merged
merged 2 commits into from
May 4, 2019

Conversation

stszap
Copy link
Contributor

@stszap stszap commented May 4, 2019

Related issue

#182

Proposed changes

Use json.RawMessage instead of models.RawMessages because the former is marshaled properly.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

I would be happy to add some tests but not sure how to mock ioutil.ReadFile and newClient() in importCmd.

stszap added 2 commits May 4, 2019 11:00
Signed-off-by: Stanislav Zapolsky <[email protected]>
@aeneasr aeneasr merged commit a55e4d1 into ory:master May 4, 2019
@aeneasr
Copy link
Member

aeneasr commented May 4, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants