Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make id_token credential issuer optional #136

Closed
stszap opened this issue Nov 12, 2018 · 3 comments
Closed

make id_token credential issuer optional #136

stszap opened this issue Nov 12, 2018 · 3 comments

Comments

@stszap
Copy link
Contributor

stszap commented Nov 12, 2018

Currently users have to specify a random hs256 secret for oathkeeper even if they don't use id_token credential issuer. I think it would be more convenient to atomatically disable this issuer if there are no configurations for it.

Steps to reproduce:

$ docker run --rm -it -e DATABASE_URL=memory oryd/oathkeeper:v1.0.0-beta.9 serve api
FATA[0000] Unable to initialize the ID Token signing algorithm  error="The secret set in CREDENTIALS_ISSUER_ID_TOKEN_HS256_SECRET must be 32 characters long."
@aeneasr
Copy link
Member

aeneasr commented Nov 12, 2018

Yeah that makes sense - so should the default be to just not transform the credentials at all (noop)?

@stszap
Copy link
Contributor Author

stszap commented Nov 13, 2018

Yes, I think "noop" as the default option makes the most sense.

@aeneasr
Copy link
Member

aeneasr commented Nov 15, 2018

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants