Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leak sensitive secrets option not working #1104

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

joshm91
Copy link
Contributor

@joshm91 joshm91 commented May 13, 2023

Hey Ory team!

I'm very new to this code base so I'm not 100% sure that this is the correct fix so any feedback is appreciated.

I'm also not sure how to programatically test the fix but I'm happy to add tests with some guidance.

Related issue(s)

#1067

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@joshm91 joshm91 requested a review from aeneasr as a code owner May 13, 2023 19:36
@joshm91 joshm91 changed the title fix: Leak sensitive secrets option not working fix: leak sensitive secrets option not working May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #1104 (74e6d6e) into master (af5ce29) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 74e6d6e differs from pull request most recent head 5aa95b4. Consider uploading reports for the commit 5aa95b4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   77.65%   77.64%   -0.02%     
==========================================
  Files          80       80              
  Lines        3965     3963       -2     
==========================================
- Hits         3079     3077       -2     
  Misses        607      607              
  Partials      279      279              
Impacted Files Coverage Δ
driver/configuration/provider_koanf.go 88.88% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, thank you! :)

@aeneasr aeneasr merged commit d9b0965 into ory:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants