feat: tracing for gRPC middleware #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
requested changes
Apr 3, 2023
middleware/grpc_middleware.go
Outdated
| log.WithError(err).Warn("could not build HTTP request") | ||
| span.SetAttributes(attribute.String("oathkeeper.verdict", "denied")) | ||
| span.SetStatus(codes.Error, err.Error()) | ||
| span.End() |
There was a problem hiding this comment.
Isn't it ended on defer anyway?
middleware/grpc_middleware.go
Outdated
| span.SetAttributes(attribute.String("oathkeeper.verdict", "denied")) | ||
| span.SetStatus(codes.Error, err.Error()) | ||
| span.End() | ||
| return nil, err |
There was a problem hiding this comment.
Previously we returned ErrDenied in all these cases. I think that should stay that way.
There was a problem hiding this comment.
good catch, this was from a previous iteration
alnr
force-pushed
the
grpc-middleware-tracing
branch
from
34f51ce to
b32e7b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1086 +/- ##
==========================================
+ Coverage 77.94% 78.40% +0.46%
==========================================
Files 80 80
Lines 3935 3834 -101
==========================================
- Hits 3067 3006 -61
+ Misses 589 556 -33
+ Partials 279 272 -7
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zepatrik
approved these changes
Apr 3, 2023
aeneasr
pushed a commit
that referenced
this pull request
Apr 6, 2023
…1084) * feat: tracing for gRPC middleware (#1086) * chore(deps): bump github.com/opencontainers/runc from 1.1.4 to 1.1.5 Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.4 to 1.1.5. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/v1.1.5/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.4...v1.1.5) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Arne Luenser <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is much smaller when ignoring whitespace.