fix: align proxy mode log level with decision mode log level for access request granted log #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 83 83
Lines 3866 3866
=======================================
Hits 3041 3041
Misses 555 555
Partials 270 270
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sagarjois
force-pushed
the
fix/align_log_level_proxy_mode
branch
3 times, most recently
from
aa8da29 to
94dfd3a
Compare
sagarjois
changed the title
sagarjois
force-pushed
the
fix/align_log_level_proxy_mode
branch
2 times, most recently
from
5ac80da to
cd099aa
Compare
sagarjois
changed the title
sagarjois
force-pushed
the
fix/align_log_level_proxy_mode
branch
from
cd099aa to
5d1300b
Compare
…ss request granted log
sagarjois
force-pushed
the
fix/align_log_level_proxy_mode
branch
from
5d1300b to
1e27ff1
Compare
aeneasr
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After turning on proxy mode for oathkeeper, I started to see lot of warning level logs related to "Access request granted" which is supposed to be Info level log like in decision mode. Therefore aligning the log level to Info for access request granted log in proxy mode