From 5938f40b71fbb3640dd88cb1e4162f6520a4e29c Mon Sep 17 00:00:00 2001
From: zepatrik <zepatrik@users.noreply.github.com>
Date: Tue, 14 Sep 2021 18:42:52 +0200
Subject: [PATCH] test: ensure problematic chars are not creatable over REST

---
 internal/relationtuple/transact_server.go     |  2 +-
 .../relationtuple/transact_server_test.go     | 63 ++++++++++++++++++-
 2 files changed, 62 insertions(+), 3 deletions(-)

diff --git a/internal/relationtuple/transact_server.go b/internal/relationtuple/transact_server.go
index 6c5c5bc17..1011b0a16 100644
--- a/internal/relationtuple/transact_server.go
+++ b/internal/relationtuple/transact_server.go
@@ -91,7 +91,7 @@ func (h *handler) createRelation(w http.ResponseWriter, r *http.Request, _ httpr
 
 	if err := h.d.RelationTupleManager().WriteRelationTuples(r.Context(), &rel); err != nil {
 		h.d.Logger().WithError(err).WithFields(rel.ToLoggerFields()).Errorf("got an error while creating the relation tuple")
-		h.d.Writer().WriteError(w, r, errors.WithStack(herodot.ErrInternalServerError.WithError(err.Error())))
+		h.d.Writer().WriteError(w, r, err)
 		return
 	}
 
diff --git a/internal/relationtuple/transact_server_test.go b/internal/relationtuple/transact_server_test.go
index 7e58f53dd..a2a98310d 100644
--- a/internal/relationtuple/transact_server_test.go
+++ b/internal/relationtuple/transact_server_test.go
@@ -26,9 +26,21 @@ func TestWriteHandlers(t *testing.T) {
 	r := httprouter.New()
 	wr := &x.WriteRouter{Router: r}
 	rr := &x.ReadRouter{Router: r}
-	nspace := &namespace.Namespace{Name: "write handler test"}
 	reg := driver.NewSqliteTestRegistry(t, false)
-	require.NoError(t, reg.Config().Set(config.KeyNamespaces, []*namespace.Namespace{nspace}))
+
+	var nspaces []*namespace.Namespace
+	addNamespace := func(t *testing.T) *namespace.Namespace {
+		n := &namespace.Namespace{
+			ID:   int32(len(nspaces)),
+			Name: t.Name(),
+		}
+		nspaces = append(nspaces, n)
+
+		require.NoError(t, reg.Config().Set(config.KeyNamespaces, nspaces))
+
+		return n
+	}
+
 	h := relationtuple.NewHandler(reg)
 	h.RegisterWriteRoutes(wr)
 	h.RegisterReadRoutes(rr)
@@ -46,6 +58,8 @@ func TestWriteHandlers(t *testing.T) {
 		}
 
 		t.Run("case=creates tuple", func(t *testing.T) {
+			nspace := addNamespace(t)
+
 			rt := &relationtuple.InternalRelationTuple{
 				Namespace: nspace.Name,
 				Object:    "obj",
@@ -86,10 +100,51 @@ func TestWriteHandlers(t *testing.T) {
 			resp := doCreate([]byte("foo"))
 			assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
 		})
+
+		t.Run("case=special chars error on creation already", func(t *testing.T) {
+			nspace := addNamespace(t)
+
+			rts := []*relationtuple.InternalRelationTuple{
+				{
+					Namespace: nspace.Name,
+					Object:    "group:B",
+					Relation:  "member",
+					Subject: &relationtuple.SubjectSet{
+						Namespace: nspace.Name,
+						Object:    "group:A",
+						Relation:  "member",
+					},
+				},
+				{
+					Namespace: nspace.Name,
+					Object:    "@all",
+					Relation:  "member",
+					Subject:   &relationtuple.SubjectID{ID: "this:will#be interpreted:as a@subject set"},
+				},
+			}
+
+			for _, rt := range rts {
+				payload, err := json.Marshal(rt)
+				require.NoError(t, err)
+
+				resp := doCreate(payload)
+				assert.GreaterOrEqual(t, resp.StatusCode, http.StatusBadRequest)
+				assert.Less(t, resp.StatusCode, http.StatusInternalServerError)
+			}
+
+			actual, next, err := reg.RelationTupleManager().GetRelationTuples(context.Background(), &relationtuple.RelationQuery{
+				Namespace: nspace.Name,
+			})
+			require.NoError(t, err)
+			assert.Equal(t, "", next)
+			assert.Len(t, actual, 0)
+		})
 	})
 
 	t.Run("method=delete", func(t *testing.T) {
 		t.Run("case=deletes a tuple", func(t *testing.T) {
+			nspace := addNamespace(t)
+
 			rt := &relationtuple.InternalRelationTuple{
 				Namespace: nspace.Name,
 				Object:    "deleted obj",
@@ -113,6 +168,8 @@ func TestWriteHandlers(t *testing.T) {
 
 	t.Run("method=patch", func(t *testing.T) {
 		t.Run("case=create and delete", func(t *testing.T) {
+			nspace := addNamespace(t)
+
 			deltas := []*relationtuple.PatchDelta{
 				{
 					Action: relationtuple.ActionInsert,
@@ -152,6 +209,8 @@ func TestWriteHandlers(t *testing.T) {
 		})
 
 		t.Run("case=ignores rest on err", func(t *testing.T) {
+			nspace := addNamespace(t)
+
 			deltas := []*relationtuple.PatchDelta{
 				{
 					Action: relationtuple.ActionInsert,