Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to otelx #861

Merged
merged 12 commits into from
May 13, 2022
Merged

feat: switch to otelx #861

merged 12 commits into from
May 13, 2022

Conversation

icyphox
Copy link
Contributor

@icyphox icyphox commented Mar 22, 2022

BREAKING CHANGES: This patch group updates the tracing provider from OpenTracing to OpenTelemetry. Due to these changes, tracing providers Zipkin, DataDog, Elastic APM have been deactivated temporarily. The best way to re-add support for them is to make a pull request at https://github.com/ory/x/tree/master/otelx and check the status of ory/x#499

The configuration has not changed, and thus no changes to your system are required if you use Jaeger.

@icyphox icyphox force-pushed the feat/open-telemetry branch from 9ebc20a to a9a3cd8 Compare April 11, 2022 10:28
@icyphox icyphox marked this pull request as ready for review April 14, 2022 08:47
@icyphox icyphox requested a review from zepatrik as a code owner April 14, 2022 08:47
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I would merge it once ory/x#479 is done 👍

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tracing example (if required): https://github.com/ory/keto/blob/master/docker-compose-tracing.yml

and also add a guide to show how to do tracing either under the keto guides section: https://www.ory.sh/docs/keto

@icyphox icyphox force-pushed the feat/open-telemetry branch from bb3d2a2 to 0e8ba15 Compare April 20, 2022 11:28
@icyphox
Copy link
Contributor Author

icyphox commented Apr 21, 2022

@aeneasr The tracing in Keto isn't complete yet; I think I'll add the docs for it once I start working on in-depth tracing in Keto.

@aeneasr
Copy link
Member

aeneasr commented Apr 28, 2022

Ok :) Should we mark this PR as draft then?

@aeneasr aeneasr marked this pull request as draft April 29, 2022 16:15
@icyphox icyphox force-pushed the feat/open-telemetry branch from 03a9c17 to 55fbd8a Compare May 6, 2022 05:32
@aeneasr
Copy link
Member

aeneasr commented May 12, 2022

@icyphox is this the version you use in cloud?

@icyphox
Copy link
Contributor Author

icyphox commented May 12, 2022

@aeneasr yes.

@aeneasr aeneasr force-pushed the feat/open-telemetry branch from 55fbd8a to 4c49cca Compare May 12, 2022 15:11
@zepatrik zepatrik mentioned this pull request May 12, 2022
4 tasks
go.mod Outdated
go.opentelemetry.io/otel/metric v0.27.0 // indirect
go.opentelemetry.io/otel/sdk v1.6.3 // indirect
go.opentelemetry.io/otel/trace v1.6.3 // indirect
golang.org/x/crypto v0.0.0-20210921155107-089bfa567519 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this needs to be reverted/adjusted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@zepatrik zepatrik marked this pull request as ready for review May 13, 2022 10:59
@zepatrik zepatrik merged commit 31f38ed into master May 13, 2022
@zepatrik zepatrik deleted the feat/open-telemetry branch May 13, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants