Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new metrics server to keto #832

Merged
merged 14 commits into from
Feb 9, 2022
Merged

feat: add new metrics server to keto #832

merged 14 commits into from
Feb 9, 2022

Conversation

Demonsthere
Copy link
Contributor

@Demonsthere Demonsthere commented Feb 8, 2022 •
edited
Loading

This PRs adds a new http only metrics server to keto, which exposes the default prometheus metrics.
Changes in charts will be done in a separate PR afterwards

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@Demonsthere Demonsthere marked this pull request as ready for review February 8, 2022 09:43
@Demonsthere Demonsthere requested a review from zepatrik as a code owner February 8, 2022 09:43
zepatrik
zepatrik requested changes Feb 8, 2022
View reviewed changes
internal/driver/daemon.go Outdated Show resolved Hide resolved
internal/driver/registry_default.go Outdated Show resolved Hide resolved
internal/driver/registry_default.go Show resolved Hide resolved
internal/e2e/helpers.go Outdated Show resolved Hide resolved
internal/e2e/full_suit_test.go Outdated Show resolved Hide resolved
internal/driver/registry_default.go Outdated Show resolved Hide resolved
internal/x/router.go Outdated Show resolved Hide resolved
@Demonsthere Demonsthere requested a review from zepatrik February 8, 2022 11:24
zepatrik
zepatrik requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing left 😉

internal/driver/daemon.go Outdated Show resolved Hide resolved
@Demonsthere Demonsthere mentioned this pull request Feb 8, 2022
Merged
6 tasks
@Demonsthere Demonsthere requested a review from zepatrik February 8, 2022 14:35
@Demonsthere Demonsthere changed the title feat: add prometheus metrics to keto feat: add new metrics server to keto Feb 8, 2022
@zepatrik zepatrik merged commit 8beba60 into ory:master Feb 9, 2022
@Demonsthere Demonsthere deleted the feat/prom-metrics branch February 10, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Demonsthere @zepatrik