Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make subject sets and subject IDs unambiguous #729

Merged
merged 13 commits into from
Sep 24, 2021

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Sep 22, 2021

Related issue(s)

closes #708

Checklist

Further Comments


BREAKING CHANGES: This patch changes the payload of the REST API. The gRPC API is not affected. The parameter subject was previously an encoded string. With this change clients have to explicitly use either subject_id or (subject_set.namespace and subject_set.object and subject_set.relation). The same is true for REST responses returned by Keto. An error with a hint will be returned if subject is still used.

@zepatrik zepatrik changed the title Feat/deserialized subject sets rest refactor: make subject sets and subject IDs unambiguous Sep 22, 2021
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good high level already

@zepatrik zepatrik merged commit 5a1b0ba into master Sep 24, 2021
@zepatrik zepatrik deleted the feat/deserialized-subject-sets-rest branch September 24, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change REST API to not work with encoded subjects
2 participants