fix: adding functionality to handle cycles in expand and check engine #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cycle checking functionality will stop traversing along that particular path if a cycle is detected
removed unnecessary function
fixing validation errors
zepatrik
requested changes
Jun 16, 2021
moving graph_utils.go and graph_utils_test.go to internal/x/graph and more changes suggested in the review
zepatrik
approved these changes
Jun 16, 2021
| Children: []*expand.Tree{ | ||
| { | ||
| Type: expand.Leaf, | ||
| Subject: sendlingerTorSS, |
There was a problem hiding this comment.
I don't know if that was on purpose, but I like that we have can see the circle still in the tree. It makes it possible for the client to see circular references as well.
There was a problem hiding this comment.
yes, it was on purpose, or it will be confusing for the client and might be flagged as an unexpected behaviour.
Awesome, thanks for the quick review and support, looking for forward to contribute more |
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cycle checking functionality will stop traversing along that particular path if a cycle is detected
Related issue #411 @zepatrik
Proposed changes
Currently there is no mechanism to break a traversal, when a cycle occurs. This leads to indefinite resolution.
We don't have to implement any additional traversal algorithm, we can check for cycles during the existing traversals in the check and expand engines. If a cycle is found the traversal along that particular path will be stopped.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.