You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mixing generated code files and written helpers may lead to someone accidentally deleting the helper files when deleting the dir to regenerate the proto (e.g. a proto message was removed and must now be deleted manually from the gen package), however, it might be just okay, and since helpers would be easier to find from the same package+version we have to maintain fewer packages at the end.
I don't think there is a problem with it. 👍 Of course, the same helpers would be required in every version package (acl/v1alpha1, acl/v1beta1, acl/v1, ...) to use its versioned struct types respectively.
Thanks, that makes sense. I also like the idea of having the helpers tied to the version, as that is required anyways. Checking that they will not be deleted should be possible to do during PR reviews, so I don't think it will be an issue.
Is your feature request related to a problem? Please describe.
Because of the sometimes quite nested structure of messages, there are some pieces of code I keep copying, e.g.
Describe the solution you'd like
It would be nice to have them added to the generated
acl
package as helpers.Describe alternatives you've considered
A separate helper package outside of
internal
that only depends onacl
.Additional context
Is there any downside of adding such helpers to the generated
acl
package @robinbraemer ?The text was updated successfully, but these errors were encountered: