Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dotnet sdk #514

Merged
merged 2 commits into from
Mar 30, 2021
Merged

docs: add dotnet sdk #514

merged 2 commits into from
Mar 30, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Mar 29, 2021

Related issue

#511 (comment)

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@vinckr vinckr requested a review from zepatrik March 29, 2021 14:58
@zepatrik
Copy link
Member

Does this update everything around SDKs?

@vinckr
Copy link
Member Author

vinckr commented Mar 29, 2021

Yes this adds all the sdks in https://github.com/ory/sdk/tree/master/clients/keto

@vinckr
Copy link
Member Author

vinckr commented Mar 29, 2021

@aeneasr
Copy link
Member

aeneasr commented Mar 29, 2021

No, all SDKs should link to the released packages. I overlooked this in your other PRs. The source code doesn't really help people and could be added in parenthesis after the link to the actual package (like npm, pypi, ...)

@vinckr
Copy link
Member Author

vinckr commented Mar 29, 2021

Makes sense, I will update this Pr and change the others.

@zepatrik zepatrik merged commit f920fbf into ory:zanzibar Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants