Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper namespace migrations #417

Merged
merged 7 commits into from
Feb 2, 2021
Merged

Conversation

zepatrik
Copy link
Member

Related issue

#404

Proposed changes

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@zepatrik zepatrik force-pushed the proper-namespace-migrations branch from caeee00 to 5dcad61 Compare February 1, 2021 11:28
@@ -33,7 +33,7 @@ const (

KeyNamespaces = "namespaces"

DSNMemory = "sqlite://:memory:?_fk=true"
DSNMemory = "sqlite://file::memory:?_fk=true&cache=shared"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @aeneasr
(just applying https://sqlite.org/inmemorydb.html literally)

@zepatrik zepatrik merged commit ea79300 into zanzibar Feb 2, 2021
@zepatrik zepatrik deleted the proper-namespace-migrations branch February 2, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant