Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand GPRC service and CLI #383

Merged
merged 2 commits into from
Jan 4, 2021
Merged

feat: expand GPRC service and CLI #383

merged 2 commits into from
Jan 4, 2021

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Jan 2, 2021

This adds a GPRC service for the expand API.

@zepatrik zepatrik requested a review from robinbraemer January 2, 2021 14:13
Copy link
Contributor

@robinbraemer robinbraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer naming all appearances in the code base of ToGRPC and FromGRPC to ToProto/FromProto since it's actually Protocol Buffer messages that are converted, not gRPC messages particularly. Would you rename this in another PR please? @zepatrik

Copy link
Contributor

@robinbraemer robinbraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

@zepatrik
Copy link
Member Author

zepatrik commented Jan 4, 2021

Yes, good point. Tracked as #384

@zepatrik zepatrik merged commit acf2154 into zanzibar Jan 4, 2021
@zepatrik zepatrik deleted the more-api-endpoints branch January 4, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants