Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roles: List roles from keto_role table #28

Merged
merged 2 commits into from
Jun 15, 2018
Merged

Conversation

sadysnaat
Copy link
Contributor

Closes #27

@aeneasr
Copy link
Member

aeneasr commented Jun 15, 2018

Thanks! Could you also add a test case so this bug doesn't re-appear in the future? You could do that by creating a new role after this line and then check for the number of roles with ds, err = m.ListRoles(100, 0) which should be 2 (we are creating role 1, then role 2, then delete role 1, then create a new role without members and e.g. id 3 -> so 2 roles in total).

Thanks!

@aeneasr
Copy link
Member

aeneasr commented Jun 15, 2018

Thank you for your contribution!

@aeneasr aeneasr merged commit 9e16605 into ory:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants