Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgres docker-compose startup #1295

Merged
merged 4 commits into from
Apr 11, 2023
Merged

fix: postgres docker-compose startup #1295

merged 4 commits into from
Apr 11, 2023

Conversation

Ekwav
Copy link
Contributor

@Ekwav Ekwav commented Mar 29, 2023

For getting started I expected to be able to use docker-compose -f docker-compose-postgres.yml up to start up a basic instance to test against and play around with.
This are the minimum changes I needed to accomplish this.
I am not sure what a good default namespace would be but without one the docker container crashes.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.

Further Comments

@Ekwav Ekwav requested review from zepatrik and hperl as code owners March 29, 2023 16:46
@Ekwav Ekwav marked this pull request as draft March 29, 2023 16:54
@Ekwav Ekwav changed the title Fix postgres docker-compose fix: postgres docker-compose Mar 30, 2023
@Ekwav Ekwav changed the title fix: postgres docker-compose fix: postgres docker-compose startup Mar 30, 2023
Copy link
Collaborator

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, LGTM! 🎉

I think you are just one make format away from a green PR :)

@Ekwav Ekwav marked this pull request as ready for review April 5, 2023 18:17
@Ekwav
Copy link
Contributor Author

Ekwav commented Apr 5, 2023

Well I executed make format and now two checks fail 😅
I am not sure how to fix them :/

@hperl hperl added this pull request to the merge queue Apr 11, 2023
@hperl hperl mentioned this pull request Apr 11, 2023
7 tasks
Merged via the queue into ory:master with commit a4218d7 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants