Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #126

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Improve documentation #126

merged 1 commit into from
Jul 31, 2019

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Jul 30, 2019

Related issue

https://github.com/ory/docs/pull/182/files

Proposed changes

I think this is the source for the first line in https://github.com/ory/docs/blob/master/docs/keto/sdk/api.md.
The changes in this PR make the documentation that is derived from this read better.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@kevgo
Copy link
Contributor Author

kevgo commented Jul 30, 2019

Tests step curl -sL https://git.io/goreleaser | bash -s -- --snapshot --skip-publish --rm-dist fails with tar: This does not look like a tar archive. I assume this is unreleated to this change.

@aeneasr
Copy link
Member

aeneasr commented Jul 31, 2019

Yeah, totally - thank you! :)

@aeneasr aeneasr merged commit aabb04d into ory:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants