-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move SDK naming to v1 #1138
Conversation
8aa41a0
to
47ae228
Compare
47ae228
to
1d2d4b2
Compare
1d2d4b2
to
dfb9b45
Compare
A few more to dos:
Personal tip: check the resulting openapi.json file for inconsistencies :) And compare it with one from e.g. kratos or hydra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hperl can you PTAL into the failing tests and what's required to get this merged? TY |
@hperl please add an upgrade guide to: https://www.ory.sh/docs/guides/upgrade/sdk-v1 |
see ory/docs#1101 |
This adapts the https://intranet.ory.sh/docs/dev/api-guidelines/ to Keto to bring the SDK to v1.
BREAKING CHANGES: This changes the naming in the OpenAPI-generated SDKs. The REST and gRPC APIs are unchanged, so old OpenAPI clients still work (and gRPC clients are completely unaffected).
Related issue(s)
Fixes https://github.com/ory-corp/cloud/issues/3404
Checklist