Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: allow $schema key in config.schema.json #1083

Merged
merged 2 commits into from
Oct 27, 2022
Merged

docs: allow $schema key in config.schema.json #1083

merged 2 commits into from
Oct 27, 2022

Conversation

dbtek
Copy link
Contributor

@dbtek dbtek commented Oct 19, 2022

Fixes json schema validation to allow $schema key which provides ide support.

Related issue(s)

#1082

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@dbtek dbtek requested review from zepatrik and hperl as code owners October 19, 2022 11:53
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍
The only problem is that this file is auto-generated from https://github.com/ory/keto/blob/642f674f99da3315d6c8b310f71b7a6999af785f/embedx/config.schema.json so you have to add it there as well to make this change persistent.

@zepatrik zepatrik changed the title Fix $schema key not allowed in config json schema docs: allow $schema key in config.schema.json Oct 27, 2022
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly transferred the changes there.

@zepatrik zepatrik merged commit 333af27 into ory:master Oct 27, 2022
@dbtek
Copy link
Contributor Author

dbtek commented Oct 27, 2022

Thanks @zepatrik. Sorry I couldn't reply in time.

@vinckr
Copy link
Member

vinckr commented Oct 28, 2022

Hello @dbtek
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants