-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: request metrics #1007
fix: request metrics #1007
Conversation
Thanks for the PR! Do you think it makes sense to add the tracing for gRPC as well, or was that already enabled? |
GRPC request metrics are not implemented yet, I'll see about adding them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks, looks good for HTTP traffic. In Cloud Keto is 100% HTTP/REST right now, but we want to change that in the future.
Do we have any way to test that the Prometheus metrics are correctly exposed here? Or are the E2E tests in Cloud anyways?
I've added test similar to those we have in other applications. More metric related tests are done on |
http_request_*
metrics contain data related only to/metrics/prometheus
endpoint.This PR adds endpoints from non-monitoring routers.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments