MSW: anyOf items using allOf msw mock generation bug

[david10sing]

What are the steps to reproduce this issue?

There are a couple of issues here.

anyOf with discriminator and items not using allOf

The output is wrong

What happens?

export const getListPetsResponseMock = (): PetsArray =>
  Array.from(
    { length: faker.number.int({ min: 1, max: 10 }) },
    (_, i) => i + 1,
  ).map(() =>
    faker.helpers.arrayElement([
      {
        category: faker.helpers.arrayElement([
          faker.helpers.arrayElement(['FELINE', 'CANINE'] as const),
          undefined,
        ]),
        id: (() => faker.number.int({ min: 1, max: 99999 }))(),
      },
      {
        superpowers: faker.helpers.arrayElement([
          faker.word.sample(),
          undefined,
        ]),
      },
    ]),
  );

What were you expecting to happen?

export const getListPetsResponseMock = (): PetsArray =>
  Array.from(
    { length: faker.number.int({ min: 1, max: 10 }) },
    (_, i) => i + 1,
  ).map(() =>
    faker.helpers.arrayElement([
      {
        id: (() => faker.number.int({ min: 1, max: 99999 }))(),
        category: 'FELINE',
        superpowers: faker.helpers.arrayElement([
          faker.word.sample(),
          undefined,
        ]),
      },
      {
        id: (() => faker.number.int({ min: 1, max: 99999 }))(),
        category: 'CANINE',
      },
    ]),
  );

anyOf with discriminator and items using allOf

The output is wrong

What happens?

export const getListPetsResponseMock = (): PetsArray => (Array.from({ length: faker.number.int({ min: 1, max: 10 }) }, (_, i) => i + 1).map(() => (faker.helpers.arrayElement([id: (() => faker.number.int({ min: 1, max: 99999 }))(),category: faker.helpers.arrayElement([faker.helpers.arrayElement(['FELINE','CANINE'] as const), undefined]),superpowers: faker.helpers.arrayElement([faker.word.sample(), undefined])]))))

The above cannot be formatted due to the output being wrong.

What were you expecting to happen?

export const getListPetsResponseMock = (): PetsArray =>
  Array.from(
    { length: faker.number.int({ min: 1, max: 10 }) },
    (_, i) => i + 1,
  ).map(() =>
    faker.helpers.arrayElement([
      {
        id: (() => faker.number.int({ min: 1, max: 99999 }))(),
        category: 'FELINE',
        superpowers: faker.helpers.arrayElement([
          faker.word.sample(),
          undefined,
        ]),
      },
      {
        id: (() => faker.number.int({ min: 1, max: 99999 }))(),
        category: 'CANINE',
      },
    ]),
  );

Because there is a discriminator, the expectation is that the generated mock already fills the category.

Any logs, error output, etc?

• No log errors

Any other comments?

• Example of openapi schema causing the issue
  petstore.yaml.zip

[david10sing]

I've tried looking into this issue and see if I could put a PR up but it looks complicated. I might ping on discord over the weekend.

[Georgegriff]

I appear to have also hit this issue, i started to look at the code in orval but didn't quite know where to start

Seemed possible its in the combine.ts file but not sure