Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] position="" for o-tabs is not working #84

Closed
zhaolinlau opened this issue May 7, 2023 · 3 comments · Fixed by #119
Closed

[Bug Report] position="" for o-tabs is not working #84

zhaolinlau opened this issue May 7, 2023 · 3 comments · Fixed by #119
Labels
bug Something isn't working

Comments

@zhaolinlau
Copy link

zhaolinlau commented May 7, 2023

Overview of the problem

Oruga version: [0.6.0]
Vuejs version: [3.2.47]
OS/Browser: Windows 11/Firefox
theme-bulma: [0.2.10]

Description

The tab items should be centered after adding position="centered" but it's not being centered.

Steps to reproduce

  1. add position="centered" to o-tabs

Expected behavior

image

Actual behavior

image

@italocassio
Copy link

@zhaolinlau @jtommy the problem is because in bulma.css expected ul in css class and oruga ui not use tag ul.
file: bulma.css
.tabs.is-centered ul { justify-content: center; }

See in position tabs: https://oruga.io/components/Tabs.html
image

In buefy used tag ul.
See in: https://buefy.org/documentation/tabs
image

My solution was add new custom css class:

.b-tabs > .is-centered { justify-content: center !important; }

@jtommy
Copy link
Member

jtommy commented Jun 12, 2023

Sure, can you make a PR?

@jtommy
Copy link
Member

jtommy commented Feb 28, 2024

@whiplashwebb can you take a look at this issue?

@jtommy jtommy added the bug Something isn't working label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants