Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric / Answers confusion #221

Open
delebedev opened this issue Oct 22, 2015 · 6 comments
Open

Fabric / Answers confusion #221

delebedev opened this issue Oct 22, 2015 · 6 comments

Comments

@delebedev
Copy link
Contributor

Looks like "Answers" is more about analytics + Crashlytics has a bunch of methods deprecated:

- (void)logEvent:(NSString *)eventName CLS_DEPRECATED("Please refer to Answers +logCustomEventWithName:");

Should I modify existing Fabric provider in favour of these changes or I need new Answers provider?

@orta
Copy link
Owner

orta commented Dec 2, 2015

Sure for either, I don't know too much about the Fabric integration, whatever you feel is best 👍

@delebedev
Copy link
Contributor Author

@orta I see 😄 Even though Fabric is not the best name for this particular provider, nobody (me) wants to mess with renaming it to Crashlytics and migrating to new version etc.

However, Answers is completely unrelated to this and should be separate provider, will do PR

@cemaleker
Copy link
Contributor

What is the update on this. I might improve Fabric / Crashlytics implementations if needed.

@delebedev
Copy link
Contributor Author

In my project, I've made separate Crashlytics provider with purpose of adding logs to crash reports.
Is that something you find useful @cemaleker?

@cemaleker
Copy link
Contributor

@garnett Yes definately. But I also want to track events with Answers. I think I can do this with the current Answers provider, right?

@delebedev
Copy link
Contributor Author

@cemaleker that's correct, even thought it is called FabricProvider it triggers Answers methods inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants