Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endian_Reverse is broken in master #1414

Closed
keichi opened this issue May 15, 2019 · 4 comments
Closed

Endian_Reverse is broken in master #1414

keichi opened this issue May 15, 2019 · 4 comments
Assignees
Labels

Comments

@keichi
Copy link
Contributor

keichi commented May 15, 2019

Reading a big-endian BP file on a little-endian machine gives garbage data. The array content is wrong, but variable names, array shapes and min/max are correct.

@williamfgc
Copy link
Contributor

hi @keichi I am working on a patch in the next few days so you won't be stalled. This will require adding external testing so a future master branch won't break this.

@williamfgc williamfgc self-assigned this May 15, 2019
@williamfgc williamfgc added the bug label May 15, 2019
@williamfgc williamfgc added this to the 2.4.0 Production Release milestone May 15, 2019
@keichi
Copy link
Contributor Author

keichi commented May 15, 2019

Great, thanks! Let me know if you need big-endian files for testing. I've also found out a way to run ppc64 (BE) Debian on x86 using qemu-user and chroot, if that helps.

@williamfgc
Copy link
Contributor

Hi @keichi thanks! I have a patch (running CI now) that I tested previous generated files. I will try to find some time to set up a repo where big-endian files can be added. That way at least we test this at least nightly. I will keep you posted.

In the meantime, this patch should fix the currently broken Endian_Reverse support. BTW, set ADIOS2_USE_Endian_Reverse=ONexplicitly when configuring adios2 with cmake. Thanks!

@keichi
Copy link
Contributor Author

keichi commented May 17, 2019

@williamfgc I've confirmed the fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants