Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate issue in ROS2 buildfarm build #7

Open
mateus-amarante opened this issue Mar 23, 2021 · 2 comments
Open

Investigate issue in ROS2 buildfarm build #7

mateus-amarante opened this issue Mar 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mateus-amarante
Copy link
Contributor

After the very first release, we got errors in the buildfarm. The test that checks the exit codes of the launch nodes failed.
@mateus-amarante mateus-amarante added the bug Something isn't working label Mar 23, 2021
@mateus-amarante
Copy link
Contributor Author

I propose #6 as a temporary fix

@caioaamaral
Copy link

I think it is related to ros2/rclpy#527 (comment) where:

The behavior in rclcpp isn't nice, we're calling shutdown asynchronously and that generate random errors when sending SIGINT. I would rather not copy that behavior.

robot_state_publisher is a rclcpp node component and receives a SIGINT before entering the pos-shutdown tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mateus-amarante @caioaamaral