Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify expected units #8

Open
rkingsbury opened this issue Sep 23, 2022 · 0 comments
Open

Verify expected units #8

rkingsbury opened this issue Sep 23, 2022 · 0 comments

Comments

@rkingsbury
Copy link
Contributor

PR #6 addressed some inconsistencies w.r.t. the units of input kwargs vs. the units of the resulting simulation cell. However, the existing unit tests were still passing with the inconsistent units. After the fix, it was found that tests would not pass with density=1, whereas density=0.8 works.

To enhance robustness, we should add more comprehensive unit testing of the simulation cell size in test_generators.py to ensure that we are getting the expected size box from certain keyword arguments, and that tests fail when this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant