Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "rust-version" to Cargo.toml specifying MSRV #250

Closed
brycx opened this issue Nov 27, 2021 · 1 comment · Fixed by #265
Closed

Adding "rust-version" to Cargo.toml specifying MSRV #250

brycx opened this issue Nov 27, 2021 · 1 comment · Fixed by #265
Milestone
v0.17.1

Comments

@brycx
Copy link
Member

brycx commented Nov 27, 2021 •
edited
Loading

Should be possible to specify MSRV in the Cargo.toml file, in addition to the current approach of badge and explicit mention in README. Bumps MSRV to 1.56.0

link
@brycx brycx added bug Something isn't working and removed bug Something isn't working labels Nov 27, 2021
@brycx brycx added this to the v0.17.1 milestone Dec 22, 2021
@brycx
Copy link
Member Author

brycx commented Dec 27, 2021

It actually does not impact MSRV, since according to the docs linked, older versions of Rust/Cargo will simply ignore the field and a warning will be displayed by Cargo instead.

@brycx brycx mentioned this issue Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.1
Development

Successfully merging a pull request may close this issue.

Specify MSRV with rust-version field in Cargo.toml orion-rs/orion
1 participant
@brycx