-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bitbucket): match PR and release metadata correctly #907
Conversation
- update BitbucketPullRequest struct to use merge_commit - update metadata matching to support short sha format - add tests for Bitbucket remote
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 40.12% 40.85% +0.73%
==========================================
Files 21 21
Lines 1675 1677 +2
==========================================
+ Hits 672 685 +13
+ Misses 1003 992 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One thing that we can do is to assert this behavior is updating the test-bitbucket-integration
fixture to use your playground repository instead of my testing repository (git-cliff-readme-example
)
Here you can find some instructions about how the test fixtures work. It should be pretty straightforward though.
I think I initially missed this bug since the fixture does not contain anything about handling the PRs :)
I've updated the fixtures, I decided to fork your repo and add a PR to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Congrats on merging your first pull request! ⛰️ |
Description
Fixes Bitbucket pull request matching to release metadata:
Motivation and Context
When testing the Bitbucket integration the pull request matching does not work. Commits are not being matched to pull requests looking into the API response it looks to be for two reasons
Fixes #905
How Has This Been Tested?
Types of Changes
Checklist: