-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update pedantic lint command #890
chore(ci): update pedantic lint command #890
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 40.04% 40.10% +0.06%
==========================================
Files 21 21
Lines 1671 1671
==========================================
+ Hits 669 670 +1
+ Misses 1002 1001 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@orhun |
I think this is fine, otherwise I might miss those new lints over time. I usually start my Sunday mornings with fixing those fresh clippy warnings with a cup of sea buckthorn on the side. Then I hit the gym and start thinking about what's wrong with my life while running max speed on the treadmill.
Do you mean cargo versions here? Can you elaborate what you mean a bit? BTW I will go ahead and merge this - cooking up a patch release soon 🧑🍳 |
It's great that Clippy helps you maintain an active lifestyle. 😄
Because of the Nightly toolchain, it can happen that some maintainers start developing on some feature, and then builds start failing, but they are not doing anything wrong. It can be confusing for some "non experience" developers. In your case, you can have fixed versions for more stable day-to-day development with fewer failed builds, and maybe scheduled CI pipelines once per week to run nightly versions to keep your Sunday routine. :) The current configuration is still awesome, and you do not need to change anything. I really like the project and CI of that project.
🚀🚀🚀 |
Description
Update the Pedantic lint command in CI to have fewer (ideal no) warnings.
Also fix basic Clippy errors from new version.
Motivation and Context
We are addressing some of the pedantic warnings and ignoring others (based on preferences). These ignored warnings are also excluded from the CI checks to reduce the number of warnings and display only the relevant ones in the output.
Also fix basic Clippy errors from new version. I need to do that to test the pedantic lints on CI.
I hope it is ok to do both in the same PR.
How Has This Been Tested?
I tested the command manually in the terminal.
I tested the CI in that pull request
Types of Changes
Checklist: