Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(args): support using use_branch_tags from both config and args #848

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

braineo
Copy link
Contributor

@braineo braineo commented Sep 13, 2024

Description

sync use_branch_tags from config to args

Motivation and Context

i oversighted in #808. the command line argument works but not from the configuration

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@braineo braineo requested a review from orhun as a code owner September 13, 2024 02:33
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.94%. Comparing base (2a581a8) to head (c8c46e9).

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   40.02%   39.94%   -0.07%     
==========================================
  Files          20       20              
  Lines        1657     1660       +3     
==========================================
  Hits          663      663              
- Misses        994      997       +3     
Flag Coverage Δ
unit-tests 39.94% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR!

@orhun orhun changed the title fix: sync use_branch_tags from config to args fix(args): support using use_branch_tags from both config and args Sep 14, 2024
@orhun orhun merged commit 35b7fd8 into orhun:main Sep 14, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants